Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to support TTL #7

Closed
martinheidegger opened this issue Jun 29, 2021 · 3 comments
Closed

Add tests to support TTL #7

martinheidegger opened this issue Jun 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@martinheidegger
Copy link
Contributor

martinheidegger commented Jun 29, 2021

The implementations should be forwarding the TTL for the txt entries returned by the server.

The API should probably look like:

{
  "links": {
    "ipfs": "QmTg....yomU"
  },
  "path": [],
  "log": [],
  "ttl": {
    "ipfs": 100
  }
}

This way the ttl can be optional, and users can choose if they implement ttl or not.

@martinheidegger martinheidegger added the enhancement New feature or request label Jun 29, 2021
@lidel
Copy link
Contributor

lidel commented Jun 30, 2021

👍 as this is a must-have feature for production use (cc ipfs/kubo#8074 (review))

Is there is an edge case where more than one TXT record for /ipfs/ content path exist (eahc with different TTL) or are we returning CONFLICT_ENTRY error for that?

@martinheidegger
Copy link
Contributor Author

If multiple TXT entries for the same key are returned it will use the higher one and put CONFLICT_ENTRY messages in the log for the others. The TTL for the returned entry would be the TTL of the returned TXT entry.

@martinheidegger
Copy link
Contributor Author

Added in de471b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants