Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SocketProtocol for DoT and DoH #8

Closed
pspacek opened this issue May 29, 2019 · 8 comments · Fixed by #10
Closed

add SocketProtocol for DoT and DoH #8

pspacek opened this issue May 29, 2019 · 8 comments · Fixed by #10

Comments

@pspacek
Copy link

pspacek commented May 29, 2019

enum SocketProtocol probably needs new values for DoT and DoH. These two transports are becoming more prevalent but dnstap cannot capture them.

@cmikk
Copy link
Member

cmikk commented Jun 1, 2019

I would like to discuss support for these transports in more depth on the dnstap mailing list before adding these values to the enum.

My main concern is the potential need for more information to make DOH instrumentation usable, given that DOH makes use of HTTP/2 mechanisms to match queries and responses.

@pspacek
Copy link
Author

pspacek commented Nov 25, 2020

That's certainly possible, but I do not think it precludes adding new values to enum.

@pspacek
Copy link
Author

pspacek commented Nov 25, 2020

@cmikk Hello! It seems the issue slipped through cracks. Do you want to start the discussion on the mailing list?

@cmikk
Copy link
Member

cmikk commented Dec 4, 2020

@pspacek - I can start this discussion early next week, unless you want to kick it off sooner.

Thanks,
-Chris

@pspacek
Copy link
Author

pspacek commented Dec 4, 2020

I would appreciate if you start, it seems you have better idea where the problem is. Thanks!

@vcunat
Copy link
Contributor

vcunat commented Dec 7, 2020

@edmonds
Copy link
Member

edmonds commented Dec 8, 2020

I like the suggestion from multiple developers to simply extend the SocketProtocol enum rather than adding a new field to specify DoT, DoH, etc. My reasoning is here: http://lists.redbarn.org/pipermail/dnstap/2020-December/000108.html.

@cmikk
Copy link
Member

cmikk commented Dec 17, 2020

Taking "no comments on PR" as agreement, and merging.

@cmikk cmikk closed this as completed in #10 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants