New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SocketProtocol for DoT and DoH #8
Comments
I would like to discuss support for these transports in more depth on the dnstap mailing list before adding these values to the enum. My main concern is the potential need for more information to make DOH instrumentation usable, given that DOH makes use of HTTP/2 mechanisms to match queries and responses. |
That's certainly possible, but I do not think it precludes adding new values to enum. |
@cmikk Hello! It seems the issue slipped through cracks. Do you want to start the discussion on the mailing list? |
@pspacek - I can start this discussion early next week, unless you want to kick it off sooner. Thanks, |
I would appreciate if you start, it seems you have better idea where the problem is. Thanks! |
I like the suggestion from multiple developers to simply extend the |
Taking "no comments on PR" as agreement, and merging. |
enum SocketProtocol probably needs new values for DoT and DoH. These two transports are becoming more prevalent but dnstap cannot capture them.
The text was updated successfully, but these errors were encountered: