use snapshot table name in its primary key name #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look good, however I do think that if we do this for the snapshot table, we also need to do this for the journal table. |
octonato
requested changes
Apr 15, 2018
There was a problem hiding this comment.
@notNotDaniel can you do the same for the journal table as well? thanks
|
Good point, I noticed the snapshot table when we were implementing a custom journal table, so didn't notice the problem there too. I'll add the change for the journal table too. |
octonato
approved these changes
Apr 23, 2018
evgenyzic
pushed a commit
to evgenyzic/akka-persistence-jdbc
that referenced
this pull request
Dec 16, 2019
* use snapshot table name in its primary key name * use journal table name in its primary key and index names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default snapshot table schema used a fixed name (
snapshot_pk) for the primary key, which makes it impossible to have more than one snapshot table in the same schema (since they both try to create the primary key with the same name). This change makes the name based on the configured table name, so that more than one can coexist.Thanks.