Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syllable Counter #455

Closed
Darren01 opened this issue Sep 22, 2020 · 2 comments
Closed

Syllable Counter #455

Darren01 opened this issue Sep 22, 2020 · 2 comments

Comments

@Darren01
Copy link
Contributor

Your syllable counter can't cope with diacritics ... noösphere has 3 syllables but is counted as having 2 ... can you fix it, please?
@ltagliaferri
Copy link
Collaborator

The syllable counter is not perfect unfortunately, so we have humans reviewing PRs too and overriding as needed. @beardicus any thoughts about this?

@beardicus
Copy link
Contributor

We use the syllable library for these tests. It is english- and ascii-focused and even then it fails occasionally. It's still useful for us as a way to triage pull requests, and we're happy to manually review any false-negatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beardicus @Darren01 @ltagliaferri