Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::str::FromStr for OpCode #3

Closed
Hasenn opened this issue Mar 12, 2021 · 1 comment
Closed

Implement std::str::FromStr for OpCode #3

Hasenn opened this issue Mar 12, 2021 · 1 comment

Comments

@Hasenn
Copy link

Hasenn commented Mar 12, 2021

As of now, in my assembler I need to redefine OpCode in order to derive that trait -- with strum's EnumString derive macro, which is a code duplication i can't really avoid. if the do-core crate did it, i could depend on it and not have to sync my assembler's instructions with do-core manually

Hasenn pushed a commit to Hasenn/do-core1 that referenced this issue Mar 12, 2021
Hasenn pushed a commit to Hasenn/do-core1 that referenced this issue Mar 19, 2021
Related issue: dev-sys-do#3
This is for do-core-asm to be able to depend on us for its opcodes needs
Hasenn pushed a commit to Hasenn/do-core1 that referenced this issue Mar 19, 2021
Related issue: dev-sys-do#3
This is for do-core-asm to be able to depend on us for its opcodes needs

Signed-off-by: Eliott Veyrier <eliott.veyrier@umontpellier.fr>
sameo pushed a commit that referenced this issue Mar 19, 2021
Related issue: #3
This is for do-core-asm to be able to depend on us for its opcodes needs

Signed-off-by: Eliott Veyrier <eliott.veyrier@umontpellier.fr>
@sameo
Copy link
Collaborator

sameo commented Mar 19, 2021

Fixed with #4

@sameo sameo closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants