Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishToConfluence:Cannot handle embedded SVG images #1300

Closed
PacoVK opened this issue Nov 20, 2023 · 0 comments · Fixed by #1301
Closed

publishToConfluence:Cannot handle embedded SVG images #1300

PacoVK opened this issue Nov 20, 2023 · 0 comments · Fixed by #1301
Labels

Comments

@PacoVK
Copy link
Collaborator

PacoVK commented Nov 20, 2023

This issue was raised by @faltfe (thanks!)
To keep the scope of #1206 i separated this one here:

There was the observation in another issue that publishToConfluence could not handle embdded SVG images. This can be reproduced if we set failOnMissingImages=true in docToolchian config.

To Reproduce
Steps to reproduce the behavior:

  1. ensure failOnMissingImages=true in docToolchian config (this is default)
  2. add the following content to the adoc file you want to publish
[plantuml,03_technical-context,svg]
....
@startuml
skinparam componentStyle uml2

foo <-u-> bar

@enduml
....
  1. run publishToConfluence
  2. The page will be created without attachment

Expected behavior
The attachment will be uploaded

Additional context
If we use e.g. png instead of svg it works as expected

@PacoVK PacoVK changed the title publishToConfluence:Cannot handle embdedded SVG images publishToConfluence:Cannot handle embedded SVG images Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant