Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtcw - sdkman installation check returns wrong result #621

Closed
uniqueck opened this issue Sep 2, 2021 · 11 comments · Fixed by #1077
Closed

dtcw - sdkman installation check returns wrong result #621

uniqueck opened this issue Sep 2, 2021 · 11 comments · Fixed by #1077

Comments

@uniqueck
Copy link
Member

uniqueck commented Sep 2, 2021

Describe the bug
sdkman is installed

To Reproduce
I tested this on ubuntu, so here command sdk returns command not found.

Expected behavior
sdkman should detected as installed.

Configuration

  • OS: Ubuntu 20.10 with zsh

Additional context
none

@uniqueck uniqueck self-assigned this Sep 2, 2021
@uniqueck
Copy link
Member Author

uniqueck commented Sep 2, 2021

A check with where sdk returns 0 for existence and 1 for unavailable. I create a pull request for that additional check.

@rdmueller
Copy link
Member

do you have a link pointing to the PR?

@uniqueck
Copy link
Member Author

uniqueck commented Sep 3, 2021

Later this evening I create this fix and create a pr

@uniqueck
Copy link
Member Author

uniqueck commented Sep 5, 2021

Where can I find the repository for the dtcw?

@rdmueller
Copy link
Member

to make it easy downloadable, dtcw is located in https://github.com/docToolchain/docToolchain.github.io
this results in doctoolchain.github.io/dtcw as download-url

@uniqueck
Copy link
Member Author

uniqueck commented Sep 6, 2021

Ok I'm confused.

If i try something like [[ "$(command -v sdk)" ]] in my terminal all is fine, but in the dtcw it is not working.
I have to investigate more time, to understand why my sdk command is not found.
If I open a bash shell and type sdk, it also work as expected.

@rdmueller
Copy link
Member

Could it be that you've installed sdkman within zshell but not bash?

@uniqueck
Copy link
Member Author

uniqueck commented Sep 7, 2021 via email

@rdmueller
Copy link
Member

how do we progress with this issue?

@uniqueck
Copy link
Member Author

For me that is ok, but i think we have to investigate to find a solution that it is working no matter which shell is used.

@rdmueller
Copy link
Member

This seems to be a general issue.
the script uses bash and when I start it from another shell, it might be that in the starting shell, a tool like sdkman or java is installed but not configured for bash.
Don't know if there is a solution for this...

@mh182 mh182 self-assigned this Apr 7, 2023
@mh182 mh182 linked a pull request Apr 7, 2023 that will close this issue
@mh182 mh182 added this to the Java 17 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants