-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOMixin for DocVec (to/from) #1330
Comments
The description needs to be changed to Doc2Vec |
When implementing this, please make sure to habdle the case shown in #1490 |
I am breaking this up into multiple PRs (will update the list as I go): |
lets not do too much abstraction here. There are no shared behavior between DocList and DocVec IO. Lets juts implement the function in both, no need for an abstract class until we can provide the same IO capacity for both |
We want to support IO functionality in
DocVec
such as from/to json, csv, bytes, etc. For example, to/from json is needed to make it FastAPI-compatible.However, we can not use the existing IOMixin here as the logic behind DocVec is different from DocList and we'd have to overwrite some functions.
Solution:
Create an abstract mixin containing functions that the two classes share, and for other functions create separate mixins inheriting from the abstract class
The text was updated successfully, but these errors were encountered: