Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pydantic 2] create pydantic model from schema #1786

Closed
samsja opened this issue Sep 15, 2023 · 1 comment · Fixed by #1795
Closed

[pydantic 2] create pydantic model from schema #1786

samsja opened this issue Sep 15, 2023 · 1 comment · Fixed by #1795
Labels
pydantic-v2
Milestone
pydantic v2 full ...

Comments

@samsja
Copy link
Member

samsja commented Sep 15, 2023 •
edited
Loading

Context

creating pydantic model from schema is not working bc pydantic v2 does not expose anymore the right method

docarray/tests/units/util/test_create_dynamic_code_class.py

Line 17 in 4ef4939

@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2 for now")

docarray/docarray/utils/create_dynamic_doc_class.py

Line 54 in 4ef4939

raise NotImplementedError(

@samsja samsja added this to the pydantic v2 full integration milestone Sep 15, 2023
@JoanFM
Copy link
Member

JoanFM commented Sep 17, 2023

Any clue why this is not doable in Pydantic V2?

@JoanFM JoanFM linked a pull request Sep 18, 2023 that will close this issue
feat: enable dynamic doc with Pydantic v2 #1795
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pydantic-v2
Projects
DocArray backlog
Status: Done
Milestone
pydantic v2 full integration
Development

Successfully merging a pull request may close this issue.

feat: enable dynamic doc with Pydantic v2 docarray/docarray
2 participants
@JoanFM @samsja