[cancelled, not using Crystal anymore] WIP Add basic param string token parser (~~~working) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'd like to clean up old PRs of mine on projects I don't follow anymore. What do we do with this PR ? Close? or do you want to take it? |
|
Following my last comment, I'm cleaning up my old PRs, and this seems to be going nowhere.. If anyone wants to ever implement this, please re-open the PR as yourself. |
bew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Currently there's only a hand-made parser (not optimized) for parameterized strings. With a method
next_token(io)that parses and returns the next token from the IO.