Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Deprecate Docker Hub token based discovery #2688

Closed
nishanttotla opened this issue Apr 28, 2017 · 3 comments
Closed

Deprecate Docker Hub token based discovery #2688

nishanttotla opened this issue Apr 28, 2017 · 3 comments

Comments

@nishanttotla
Copy link
Contributor

nishanttotla commented Apr 28, 2017

It isn't recommended, nor a reliable way to do service discovery. We should start to deprecate it with the goal of completely removing it two releases from now.

cc @docker/core-swarm-maintainers

Related:
#2675
#2679

@nishanttotla nishanttotla added this to the 1.2.7 milestone Apr 28, 2017
@nishanttotla
Copy link
Contributor Author

nishanttotla commented May 4, 2017

We should add a line to the release saying that token based discovery will be deprecated after two releases.

We may not be able to print a warning during swarm create because it'll break the API.

@nishanttotla
Copy link
Contributor Author

@dongluochen @aluzzardi any suggestions on how to add this deprecation? The most obvious place to do it would have been to print a warning message when creating a cluster using token discovery, but that might break use cases for people who rely on only a token being printed out on cluster create.

@aluzzardi
Copy link
Contributor

Print the warning to stderr

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants