Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Stop allowing the passing of HostConfig on Container Start #2741

Closed
nishanttotla opened this issue Jun 20, 2017 · 0 comments
Closed

Stop allowing the passing of HostConfig on Container Start #2741

nishanttotla opened this issue Jun 20, 2017 · 0 comments
Assignees
@nishanttotla
Labels
area/API impact/api impact/deprecation
Milestone
future

Comments

@nishanttotla
Copy link
Contributor

This push was started last year (#1879), but never quite completed, because the only thing remaining was to stop allowing the passing of HostConfig on ContainerCreate, which was deprecated in Docker a while back. Swarm users still needed it so we kept it around, but we should remove it now.

This will significantly simplify the code and remove and unnecessary dependency.

Opening a separate issue to keep it more specific from the overall proposal in #1879.
@nishanttotla nishanttotla added this to the 1.2.8 milestone Jun 20, 2017
@nishanttotla nishanttotla self-assigned this Jun 20, 2017
@nishanttotla nishanttotla changed the title Remove depencency samalba/dockerclient Deprecate HostConfig on ContainerCreate Jun 20, 2017
@nishanttotla nishanttotla changed the title Deprecate HostConfig on ContainerCreate Deprecate passing HostConfig on ContainerCreate Jun 20, 2017
@nishanttotla nishanttotla changed the title Deprecate passing HostConfig on ContainerCreate Stop allowing the passing of HostConfig on ContainerCreate Jul 5, 2017
@nishanttotla nishanttotla changed the title Stop allowing the passing of HostConfig on ContainerCreate Stop allowing the passing of HostConfig on ContainerStart Jul 5, 2017
@nishanttotla nishanttotla changed the title Stop allowing the passing of HostConfig on ContainerStart Stop allowing the passing of HostConfig on Container Start Jul 5, 2017
@nishanttotla nishanttotla mentioned this issue Jul 5, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nishanttotla nishanttotla

Labels
area/API impact/api impact/deprecation
Projects
None yet
Milestone
future
Development

No branches or pull requests
1 participant
@nishanttotla