Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why void from load image command executed? Can't we return the official response result? #1194

Closed
vangogh-ken opened this issue May 15, 2019 · 24 comments

Comments

@vangogh-ken
Copy link

It's should be key information of loading an image into docker

HTTP/1.1 200 OK
Content-Type: application/json
Transfer-Encoding: chunked

{"stream":"Loaded image: busybox:latest\n"}

@TannerYoung
Copy link

This would be useful for my use case (loading an image from a tar file, then using test-containers). There are a couple of workarounds which are all annoying.

  1. Know both the file path name and the resulting image name.
  2. Know the file path name, run LoadImageCmd, and simultaneously untar the file and inspect the manifest.json programmatically. This introduces an unnecessary dependency on both untar and json parsing.

@babycoderz
Copy link

@vangogh-ken Hello, I have encountered the same problem now, need to get the return value of loadImageCmd, get the image name and tag. Is there any good solution?

@codeseedr
Copy link

Any plans on returning the identifier of the loaded image? It looks like a clear omission to me.

@codeseedr
Copy link

Seems like the command response does not include image ID... Reported the issue upstream: docker/cli#2212

@stale
Copy link

stale bot commented Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@codeseedr
Copy link

Bump.

@stale stale bot removed the resolution/stale label Jul 19, 2020
@stale
Copy link

stale bot commented Aug 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@AgentOak
Copy link

Bump

@stale stale bot removed the resolution/stale label Aug 18, 2020
@codeseedr
Copy link

Can I ask everybody interested in getting this fixed to thumb up/comment on the prerequisite docker issue: docker/cli#2212? Thank you!

@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@codeseedr
Copy link

Lack of activity does not mean that the issue has become invalid. Or there's no one interested in getting it fixed.

@stale stale bot removed the resolution/stale label Sep 17, 2020
@bsideup
Copy link
Member

bsideup commented Sep 18, 2020

there's no one interested in getting it fixed.

If there is anyone who is willing to work on this they are more than welcome to!
Although there doesn't seem to be enough activity in the upstream issue

@stale
Copy link

stale bot commented Oct 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@AgentOak
Copy link

Still not stale

@stale stale bot removed the resolution/stale label Oct 18, 2020
@stale
Copy link

stale bot commented Nov 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@codeseedr
Copy link

Bump.

@bsideup
Copy link
Member

bsideup commented Nov 17, 2020

There is no point in bumping unless it gets implemented on the Docker API side:

docker/cli#2212 (comment)

@codeseedr
Copy link

What are the chances it gets implemented if the upstream issue eventually gets fixed but this one would have already been stale for a long time?

@bsideup
Copy link
Member

bsideup commented Nov 17, 2020

There wilk be another "Support this new API" issue :)

@stale stale bot removed the resolution/stale label Nov 17, 2020
@codeseedr
Copy link

OK, sounds good.

@stale
Copy link

stale bot commented Dec 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Dec 24, 2020
@ghost
Copy link

ghost commented Jan 15, 2021

This would be useful for my use case (loading an image from a tar file, then using test-containers). There are a couple of workarounds which are all annoying.

  1. Know both the file path name and the resulting image name.

@TannerYoung - Mind sharing how you were able to accomplish this workaround? It seems pretty reasonable to me.

@vipingupta5352
Copy link

This would be useful for my use case (loading an image from a tar file, then using test-containers). There are a couple of workarounds which are all annoying.

  1. Know both the file path name and the resulting image name.
  2. Know the file path name, run LoadImageCmd, and simultaneously untar the file and inspect the manifest.json programmatically. This introduces an unnecessary dependency on both untar and json parsing.

@TannerYoung can you please share how did you implement this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants