Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official? #11

Closed
efrecon opened this issue Dec 13, 2017 · 6 comments
Closed

Official? #11

efrecon opened this issue Dec 13, 2017 · 6 comments

Comments

@efrecon
Copy link

efrecon commented Dec 13, 2017

Maybe this isn't the proper place to ask, but is there any particular reason the prototyping that has occurred within these images haven't made its way into the official images? HEALTHCHECK is an advertised feature of Dockerfiles and it feels that official images should show the way forward and demonstrate how to check upon themselves.

@tianon
Copy link
Member

tianon commented Dec 13, 2017

Yes, see docker-library/cassandra#76 (comment) (which we should add to the README here as well).

@efrecon
Copy link
Author

efrecon commented Dec 13, 2017

Thanks for the reply. I found the thread that you are referring to a bit later. As future is kind of uncertain, I went for a solution that should provide all redis images at once, now and forward. I think that the idea should be applicable to most images, but with a different HEALTHCHECK that is. My hooks for build and push are more or less image independent. BTW, I blatantly stole your redis HEALTHCHECK code, hope this is ok.

@efrecon
Copy link
Author

efrecon commented Dec 20, 2017

Would you accept PRs for these files (and dirs). I am slowly putting into place solutions that do not require bash (so they can run on top of Alpine as well) and can automatically be built. Migrating this might however need some changes to the various settings on the hub.

@efrecon
Copy link
Author

efrecon commented May 21, 2018

ping?

@tianon
Copy link
Member

tianon commented Oct 9, 2018

Sorry for the delay.

BTW, I blatantly stole your redis HEALTHCHECK code, hope this is ok.

Absolutely, that's the whole point of this repository!

See docker-library/cassandra#76 (comment) -- this repository exists precisely as an example for users to set up their own HEALTHCHECKs which are relevant to their deployments. Many users are going to need modifications, etc, which is why I'd honestly not recommend users use these images directly, and why I'd be hesitant to do things like tag multiple versions which might encourage more users to do so.

@tianon tianon mentioned this issue Oct 9, 2018
@tianon
Copy link
Member

tianon commented Apr 22, 2020

See https://github.com/docker-library/faq#healthcheck for more detail about why these are intentionally separate.

@tianon tianon closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants