Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 10.2, including a "development" tag (to hopefully make it clear this is the "development release", not stable) #83

Merged
merged 1 commit into from May 17, 2017

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Sep 16, 2016

fixes #98

@yosifkit
Copy link
Contributor

development has the "follows the development git branch" connotation; maybe alpha is better: https://downloads.mariadb.org/mariadb/10.2.1/?

Maybe we just need big warnings on the docs page?

@tianon
Copy link
Contributor Author

tianon commented Sep 20, 2016

I wanted alpha originally, but that's going to change to beta at some point and unless we're watching really diligently, we won't notice the change (see https://mariadb.com/kb/en/mariadb/what-is-mariadb-101/#list-of-all-mariadb-101-releases -- 10.1.2 was Alpha but 10.1.3 was Beta and 10.1.7 was RC). If there's an easy way for generate-stackbrew-library.sh to determine alpha/beta/etc. status for a given release version in an automated way, I'm definitely very +1 to using alpha instead.

@tianon
Copy link
Contributor Author

tianon commented Sep 20, 2016

I wonder if there's a more machine-friendly version of https://downloads.mariadb.org/mariadb/+releases/ somewhere.

@yosifkit
Copy link
Contributor

Not sure about a machine readable version, but here is a fragile sample parser of the current page:

version=10.2; curl -fsSL https://downloads.mariadb.org/mariadb/+releases/ \
| awk '{ 
    if (match($0, /mariadb\/('"$version"'[^\/]*)\//, ver)) { c=1; print ver[1] }
    if (c==1) {
        if (match($0, /.*td>([A-Za-z ]+)<\/td.*/, ary)) { print ary[1] };
        if (/\/tr/) c=0
    } 
}'

@yosifkit
Copy link
Contributor

So my more complete idea is to use the awk in update.sh (which is where our hacky html sed/awk parsing usually lives) and have it make or delete a variant file that would tell us if that version is alpha, beta, or rc. Then generate-stackbrew just checks for a variant file and uses that in the tag generation.

Copy link

@scoutman57 scoutman57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to update the 10.2 Dockerfile for 10.2.2 which is the latest beta.

@tianon
Copy link
Contributor Author

tianon commented May 16, 2017

https://downloads.mariadb.org/mariadb/+releases/ -- 10.2 is now in Release Candidates stages, and 10.3.0 is Alpha

I'm thinking maybe we should simply give up on aliases for now and link to the "releases" page directly (and leave it up to users to figure out what's what). Sound fair? (@yosifkit)

(Then we only maintain latest pointing to the latest non-pre-release.)

@tianon tianon requested a review from yosifkit May 17, 2017 21:16
@tianon
Copy link
Contributor Author

tianon commented May 17, 2017

Updated what what I've proposed (and included 10.3).

@yosifkit yosifkit merged commit 0e47b2c into MariaDB:master May 17, 2017
@yosifkit yosifkit deleted the 10.2 branch May 17, 2017 21:40
@denji

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Docker image for 10.2.3
4 participants