Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts and virtual conf split #11

Merged
merged 10 commits into from Aug 10, 2015
Merged

Accounts and virtual conf split #11

merged 10 commits into from Aug 10, 2015

Conversation

egavard
Copy link
Contributor

@egavard egavard commented Aug 5, 2015

#10 Separate virtuals and accounts.

@egavard egavard changed the title Dev Accounts and virtual conf split Aug 5, 2015
@tomav
Copy link
Contributor

tomav commented Aug 5, 2015

Good job @dy0nysos!
But I'm thinking that aliases and redirects are 2 different things (and we need both).

user@domain.tld|otheruser@domain.tld,otheruser@otherdomain.tld is nice but with this, we have to manage 1 entry per alias, no?
I mean 1 real account, with 50 aliases will have 1 entry or 50 entries?

@egavard
Copy link
Contributor Author

egavard commented Aug 6, 2015

Sorry I thought I answered your question.

Here I'm managing redirects only. user@domain.tld to otheruser@domain.tld,anotherone@domain.tld etc.

In facts, if you need one mail to have several aliases, you'll have one line per alias.

Can you see a ( new ? ) file structure that will allows us to have several aliases for one email on a single line ?

Maybe could we add another conf file, aliases.cf with that kind of structure :
mailtobealiased|alias1,alias2,alias3 or something of this kind ?

@tomav
Copy link
Contributor

tomav commented Aug 6, 2015

Yes, this kind of format existed before the PR, aliases were managed, not redirects.

The point is that accounts.cf remains mandatory and must be parsed when the container starts because there are commands to execute to create these accounts.

We can add a new file format and parse it, but I think it's not really necessary.
Aliases and redirects may be static files in postfix format, just copied from /tmpto /etc/postfix/virtual.

Aliases and redirects are managed the same way.
http://www.postfix.org/VIRTUAL_README.html#forwarding

Sorry, I'm on vacation and can't do more than answering at this time.
I'll be back on monday.

@egavard
Copy link
Contributor Author

egavard commented Aug 6, 2015

Okay, I'll change my code to change the behavior according to your proposition.

Enjoy your vacation ! 👍

tomav added a commit that referenced this pull request Aug 10, 2015
Now `aliases` and `redirects` are managed in static files copied to `postfix` directory.
@tomav tomav merged commit 0ed01e5 into docker-mailserver:master Aug 10, 2015
@tomav
Copy link
Contributor

tomav commented Aug 10, 2015

Thank you.

tomav added a commit that referenced this pull request Aug 10, 2015
@tomav
Copy link
Contributor

tomav commented Aug 10, 2015

I don't know why build fails on the docker registry. I'm re-trying locally.

@tomav
Copy link
Contributor

tomav commented Aug 10, 2015

I'm not blind, it works locally. Waiting for the registry.

@egavard egavard deleted the dev branch August 10, 2015 10:39
@tomav
Copy link
Contributor

tomav commented Aug 10, 2015

Latest docker registry build is done.
https://hub.docker.com/r/tvial/docker-mailserver/builds/bjkcm6jaq4bzfaizu5mqhrp/

@egavard
Copy link
Contributor Author

egavard commented Aug 10, 2015

Nice !

tomav added a commit that referenced this pull request Sep 12, 2015
Now `aliases` and `redirects` are managed in static files copied to `postfix` directory.
tomav added a commit that referenced this pull request Sep 12, 2015
georglauterbach added a commit that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants