Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #1795

Merged
merged 3 commits into from Feb 7, 2021
Merged

Add PR template #1795

merged 3 commits into from Feb 7, 2021

Conversation

wernerfred
Copy link
Member

@wernerfred wernerfred commented Feb 6, 2021

Description

There are a lot of PRs on this repository where the author provides code changes without any or only little information about the motivation and context. This PR will introduce a PR template according to the github docs as we already use for issues. My hope is that contributors will more likely use this template to provide the information and insights others need to understand the changes.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or ENVIRONMENT.md or the Wiki)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wernerfred wernerfred added area/enhancement kind/new feature A new feature is requested in this issue or implemeted with this PR priority/low labels Feb 6, 2021
@wernerfred wernerfred self-assigned this Feb 6, 2021
@georglauterbach
Copy link
Member

LGTM

@wernerfred wernerfred merged commit df3ef48 into docker-mailserver:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new feature A new feature is requested in this issue or implemeted with this PR priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants