Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version variable #1976

Merged
merged 6 commits into from
May 17, 2021
Merged

Conversation

casperklein
Copy link
Member

Description

This adds a variable to let the container know, which version is running.

Fixes #1946

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this May 16, 2021
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/low labels May 16, 2021
@casperklein casperklein requested a review from a team May 16, 2021 23:46
polarathene
polarathene previously approved these changes May 17, 2021
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to prefix it? (DMS_VERSION)

VERSION is a bit generic of an ENV var name for this imo, but I'm not too fussed.

wernerfred
wernerfred previously approved these changes May 17, 2021
@georglauterbach
Copy link
Member

georglauterbach commented May 17, 2021

If you incorporate @polarathene's sugggested changes, feel free to merge without my approval :D

LGTM

@casperklein casperklein enabled auto-merge (squash) May 17, 2021 12:01
@casperklein casperklein merged commit 225e21e into docker-mailserver:master May 17, 2021
@wernerfred wernerfred added this to the v10.0.0 milestone May 18, 2021
@casperklein casperklein deleted the add-version-env branch June 19, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Include env variable or file containing the image version
4 participants