-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version variable #1976
Merged
casperklein
merged 6 commits into
docker-mailserver:master
from
casperklein:add-version-env
May 17, 2021
Merged
Add version variable #1976
casperklein
merged 6 commits into
docker-mailserver:master
from
casperklein:add-version-env
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperklein
added
area/scripts
kind/improvement
Improve an existing feature, configuration file or the documentation
priority/low
labels
May 16, 2021
polarathene
previously approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to prefix it? (DMS_VERSION
)
VERSION
is a bit generic of an ENV var name for this imo, but I'm not too fussed.
wernerfred
previously approved these changes
May 17, 2021
georglauterbach
previously approved these changes
May 17, 2021
If you incorporate @polarathene's sugggested changes, feel free to merge without my approval :D LGTM |
casperklein
dismissed stale reviews from georglauterbach, wernerfred, and polarathene
via
May 17, 2021 11:59
2e81e24
georglauterbach
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/scripts
kind/improvement
Improve an existing feature, configuration file or the documentation
priority/low
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a variable to let the container know, which version is running.
Fixes #1946
Type of change
Checklist:
docs/
)