Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworked mail_crypt guide to make things way more simple and prepare … #2043

Merged

Conversation

NorseGaud
Copy link
Member

…for user folder encryption

Description

Preparing for per folder/user encryption guide per #1904 discussion by cleaning up and simplifying the mail_crypt guide. Also, not enabling mail_crypt globally doesn't allow doveadm mailbox cryptokey to work: http://dovecot.2317879.n4.nabble.com/doveadm-mailbox-cryptokey-not-found-td58533.html

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@NorseGaud NorseGaud force-pushed the mail-crypt-doc-improvements branch from c1c70de to 7226b3c Compare June 18, 2021 04:18
wernerfred
wernerfred previously approved these changes Jun 18, 2021
Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georglauterbach georglauterbach added area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/low service/dovecot labels Jun 18, 2021
@georglauterbach georglauterbach added this to the v10.0.1 milestone Jun 18, 2021
docs/content/config/security/mail_crypt.md Outdated Show resolved Hide resolved
docs/content/config/security/mail_crypt.md Outdated Show resolved Hide resolved
docs/content/config/security/mail_crypt.md Outdated Show resolved Hide resolved
docs/content/config/security/mail_crypt.md Outdated Show resolved Hide resolved
docs/content/config/security/mail_crypt.md Show resolved Hide resolved
Co-authored-by: Casper <casperklein@users.noreply.github.com>
NorseGaud and others added 3 commits June 18, 2021 08:22
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
Co-authored-by: Casper <casperklein@users.noreply.github.com>
wernerfred
wernerfred previously approved these changes Jun 18, 2021
Co-authored-by: Casper <casperklein@users.noreply.github.com>
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 0b8ee4d

@casperklein casperklein merged commit 9c5d6ad into docker-mailserver:master Jun 19, 2021
@wernerfred
Copy link
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Contributor

@wernerfred

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 396

@wernerfred wernerfred mentioned this pull request Jul 8, 2021
11 tasks
@wernerfred
Copy link
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Contributor

@wernerfred

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 395

@wernerfred wernerfred mentioned this pull request Jul 8, 2021
7 tasks
@wernerfred
Copy link
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Contributor

@wernerfred

I've put up a pull request to add @NorseGaud! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/low service/dovecot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants