Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS SES configuration doc #2105

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Update AWS SES configuration doc #2105

merged 2 commits into from
Jul 29, 2021

Conversation

andrewlow
Copy link
Contributor

@andrewlow andrewlow commented Jul 29, 2021 •
edited by wernerfred

Description

AWS SES configuration changed, Instead of just a warning pointing people to the standard relay doc, I've re-written it with some guidance on gathering the right information from AWS and getting the configuration correct.

This doc update was requested as part of the discussion on this issue:
#2091 (comment)

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

(ok, this is just a doc change - most of the checklist is N/A)

wernerfred
wernerfred approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@wernerfred
Copy link
Member

@all-contributors add @andrewlow for documentation

@allcontributors allcontributors bot mentioned this pull request Jul 29, 2021
Merged
@allcontributors
Copy link
Contributor

@wernerfred

I've put up a pull request to add @andrewlow! 🎉

@georglauterbach georglauterbach added area/documentation kind/improvement Improve an existing feature, configuration file or the documentation labels Jul 29, 2021
@georglauterbach georglauterbach added this to the v10.0.1 milestone Jul 29, 2021
@georglauterbach georglauterbach enabled auto-merge (squash) July 29, 2021 20:29
@georglauterbach georglauterbach merged commit 016d902 into docker-mailserver:master Jul 29, 2021
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 04cca9a

@andrewlow andrewlow deleted the ses-doc-update branch July 29, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@andrewlow andrewlow

Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v10.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewlow @wernerfred @georglauterbach