HOSTNAME and DOMAINNAME setting improvements #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorseGaud
added
kind/improvement
…omain doc: OVERRIDE_HOSTNAME takes priority
NorseGaud
force-pushed
the
better-hostname-check
branch
from
50cca4d
to
3acecc3
Compare
added 3 commits
September 6, 2021 22:00
…lock': Stale file handle
…AME ENV to override what would be automatically set
NorseGaud
changed the title
georglauterbach
requested changes
Sep 8, 2021
|
I'm fine with disabling the unreliable tests :) |
polarathene
previously approved these changes
Sep 9, 2021
|
Waiting for #2177, then rebasing, then merge this :) |
|
Is this something that should be mentioned in docs at all beyond the env? How is this FAQ entry affected? |
|
I think this is backend logic and it is not absolutely necessary to mention it. If one would like to do it, I'm fine with it as well. |
|
@NorseGaud feel free to merge this PR when tests pass and you think you have completed the checklist above :) |
casperklein
previously approved these changes
Sep 11, 2021
NorseGaud
dismissed stale reviews from polarathene and georglauterbach
via
8290bcc
|
Documentation preview for this PR is ready! 🎉 Built with commit: 5ec465a |
casperklein
approved these changes
Sep 11, 2021
polarathene
approved these changes
Sep 11, 2021
|
Thanks y'all :) |
NorseGaud
added a commit
to NorseGaud/docker-mailserver
that referenced
this pull request
Sep 17, 2021
Centralize the collection of the HOSTNAME and DOMAINAME so that it's predictable and uniform across the various scripts (using the helper). Ensure it supports the various configurations users can have (both subdomain and without subdomain, override and no override). --- * using _obtain_hostname_and_domainname helper + covers when not a subdomain doc: OVERRIDE_HOSTNAME takes priority * added tests for non-subdomain hostname + further improvements * moved SRS DOMAINANME tests into hostname test file + Allowing DOMAINNAME ENV to override what would be automatically set --- Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
NorseGaud
added a commit
to NorseGaud/docker-mailserver
that referenced
this pull request
Sep 17, 2021
Centralize the collection of the HOSTNAME and DOMAINAME so that it's predictable and uniform across the various scripts (using the helper). Ensure it supports the various configurations users can have (both subdomain and without subdomain, override and no override). --- * using _obtain_hostname_and_domainname helper + covers when not a subdomain doc: OVERRIDE_HOSTNAME takes priority * added tests for non-subdomain hostname + further improvements * moved SRS DOMAINANME tests into hostname test file + Allowing DOMAINNAME ENV to override what would be automatically set --- Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: I don't use a subdomain, so HOSTNAME in the code becomes just the TLD of my domain and causes several issues (primarily with
_monitored_files_checksums). I think requiring OVERRIDE_HOSTNAME adds unnecessary complexity and isn't easy to figure out for new users without spending some time.Solution: Centralize the collection of the HOSTNAME and DOMAINAME so that it's predictable and uniform across the various scripts (using the helper). Ensure it supports the various configurations users can have (both subdomain and without subdomain, override and no override).
Also, DOMAINNAME as an env is supported for overriding SRS_DOMAINNAME, but not any other logic. Now that it's all using the same logic, specifying DOMAINNAME should override anywhere it shows up and is used in the code.
Type of change
Checklist:
docs/)