Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: version v10.2.0 #2217

Merged
merged 6 commits into from Oct 7, 2021
Merged

release: version v10.2.0 #2217

merged 6 commits into from Oct 7, 2021

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Sep 26, 2021

Description

This PR marks the feature freeze phase for v10.2.0 release. The current :edge image will be tested for roughly one week and if no bugs get reported v10.2.0 will be released. During this testing period, only PRs that do not change functionaility will be merged.

If you want to support us give the latest :edge image a try and report any issues you might (hopefully not) encounter back to this PR.

Feature free is in place until 03 Oct 2021. Documentation updates may be merged.

Type of change

  • Release

Release-Checklist:

  • Update CHANGELOG.md
  • Update version in VERSION
  • Draft release

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Closes #2211

@georglauterbach
Copy link
Member Author

I just deployed :edge for testing. Noticed that, because of my custom SSL setup, I had to change some stuff. Therefore, I'd like to explicitly mention this on the release page too.

@polarathene

This comment has been minimized.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@casperklein

This comment has been minimized.

@polarathene

This comment has been minimized.

@georglauterbach

This comment has been minimized.

georglauterbach and others added 2 commits September 27, 2021 13:18
My review feedback, covered in release highlights and an added security section.

Prioritized the script improvements section over misc.
@georglauterbach
Copy link
Member Author

Noticed that, because of my custom SSL setup, I had to change some stuff.

Details?

I use a custom setup-stack.sh (which is weird enough 😂) and a completely custom Postfix main.cf that I had to adjust to match the new functions / locations. This is a more complicated setup where even minor version changes are expected to be breaking (obviously, when adjusting the startup procedure). I just wanted everyone using such a procedure to know that with v10.2.0, there may be "breaking" changes for them:)

@polarathene
Copy link
Member

that I had to adjust to match the new functions / locations.

Is that related to the internal cert location changing for Postfix and Dovecot configs? I have covered that warning early in the release notes :)

If you have specific custom needs for SSL, let me know and perhaps we can better accommodate that without having to carry patches around that rely on our internals :)

I would like to see setup-stack.sh split out into smaller scripts eventually though, eg SSL functionality and anything else that would isolate well.

@MohammedNoureldin
Copy link
Contributor

MohammedNoureldin commented Sep 28, 2021

Thank you very much for your efforts, I have been following and using this repo for the last few weeks. If any of the reviewer is busy (as I can see), and you need someone else to finish reviewing the build notes to release the 10.2.0. I would be glad to do the review.

Btw, I myself am waiting for this release because of the built-in setup.sh :D

@casperklein
Copy link
Member

and you need someone else to finish reviewing the build notes

The more people take a look at it, the better 👍 Review/Comment as you like, there is no special permission needed.

@MohammedNoureldin
Copy link
Contributor

MohammedNoureldin commented Sep 28, 2021

For me everything seems to be ok.

Just regarding this:

  • [general] Updated default value of ONE_DIR to 1 #2148

I don't think this is relevant? as the default value is already 1.


I will start testing the edge Docker image today.

@polarathene
Copy link
Member

I don't think this is relevant? as the default value is already 1.

Not for versions prior to 10.2 which this is about. edge is unstable/beta that reflects current master branch.

@georglauterbach
Copy link
Member Author

@MohammedNoureldin you could be of great help by testing :edge and reporting any suspicious behaviour or bugs you encounter.

@MohammedNoureldin
Copy link
Contributor

@polarathene oh right, sorry. I was checking the master (namely the edge).

@georglauterbach, sure, I am just finishing setting up my docker-compose file and combine different services, I will deploy them next to the Email server probably today at night.

@MohammedNoureldin

This comment has been minimized.

@casperklein

This comment has been minimized.

@polarathene

This comment has been minimized.

@georglauterbach

This comment has been minimized.

@georglauterbach

This comment has been minimized.

@polarathene

This comment has been minimized.

@georglauterbach

This comment has been minimized.

@casperklein

This comment has been minimized.

@georglauterbach georglauterbach added the meta/needs triage This issue / PR needs checks and verification from maintainers label Oct 1, 2021
@MohammedNoureldin

This comment has been minimized.

@MohammedNoureldin
Copy link
Contributor

MohammedNoureldin commented Oct 1, 2021

@georglauterbach @casperklein @polarathene
Please check the issue #2232

@georglauterbach I am very glad to support this awesome project! :)

@polarathene
Copy link
Member

Issue was resolved, discussion here has been hidden as a result.

The problem was due to not re-creating containers between restarts which persisted the modified container state (deleted files from initial startup were not existing upon the 2nd startup run as internal storage was restored instead of the expected fresh state.

While we could better document the container state issue and how to ensure you start with freshly created containers, it's also decided that the error handling logic affected here should emit a warning log, not a fatal one that induces a shutdown.

@georglauterbach georglauterbach removed the meta/needs triage This issue / PR needs checks and verification from maintainers label Oct 2, 2021
@georglauterbach georglauterbach requested a review from a team October 3, 2021 13:30
@MohammedNoureldin
Copy link
Contributor

MohammedNoureldin commented Oct 3, 2021

Sorry for popping up again, but I have seen another potential issue. Could you check it? I don't want though to ruin this pull request :), but this seems to be relatively critical if it is really a bug and I am not wrong.

Here is the issue #2238

@casperklein
Copy link
Member

DMS version: Tested with 10.1.2 and 10.2.0

The issue is also with 10.1.2?

@MohammedNoureldin
Copy link
Contributor

MohammedNoureldin commented Oct 3, 2021

DMS version: Tested with 10.1.2 and 10.2.0

The issue is also with 10.1.2?

Yes I tested it with 10.2.0 and 10.1.2 and both showed this problem

@casperklein
Copy link
Member

So no regression from 10.1.2 to 10.2.0. Therefore no reason to hold back this release.

@georglauterbach
Copy link
Member Author

ETA for this PR (release date): Wednesday, 06th Oct 2021, evening

@NorseGaud

This comment has been minimized.

@georglauterbach

This comment has been minimized.

@casperklein

This comment has been minimized.

@NorseGaud
Copy link
Member

Hey guys, we're good. Thanks

@MohammedNoureldin
Copy link
Contributor

My F5 button started to melt down xD

@georglauterbach
Copy link
Member Author

Sorry for the delay - I was unexpectedly busy yesterday. Here we go!

@georglauterbach georglauterbach merged commit 0a3f954 into master Oct 7, 2021
@georglauterbach georglauterbach deleted the v10.2.0 branch October 7, 2021 08:44
@georglauterbach
Copy link
Member Author

Image should be available in approximately one hour.

@polarathene polarathene mentioned this pull request Nov 13, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release This PR marks a release priority/high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NOT A BUG] ./setup.sh not running
5 participants