Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deps): bump mkdocs-material to 7.3.2 #2244

Merged
merged 6 commits into from
Oct 17, 2021
Merged

Conversation

wernerfred
Copy link
Member

Description

bump mkdocs-material to 7.3.2

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wernerfred
Copy link
Member Author

This new version now shows files/links on the left site even if there is only one site (home/faq/introduction/...):
image

imho we should see if it is removeable?

@georglauterbach

This comment has been minimized.

@polarathene
Copy link
Member

I raised an issue at mkdocs-material, and identified where the regression was introduced in 7.3.1.

Waiting on the maintainer response if we need to maintain another fix ourselves or if they'll deem it as a valid regression and resolve it on their end.

@wernerfred
Copy link
Member Author

Thanks!

@polarathene
Copy link
Member

polarathene commented Oct 17, 2021

As expected. Maintainer does not consider it a bug, we need to handle this ourselves.

Adding this to the CSS should resolve it:

@media screen and (min-width: 76.25em) {
  .md-nav--lifted>.md-nav__list>.md-nav__item--active>.md-nav__link {
    display: none;
  }
}

Note that it's not a particularly nice to maintain solution. Plenty of room there for changes upstream that could break this rather specific CSS selector.

@polarathene polarathene marked this pull request as ready for review October 17, 2021 10:11
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 6a91da5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants