-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: version v10.4.0 #2328
release: version v10.4.0 #2328
Conversation
I recommend approving such kind of PRs only after successful testing. |
You're right, will do. |
"Don't count your chickens before they are hatched." @casperklein you we're right. I just checked the logs again and found something... (but nothing serious). Enough to block this PR though until #2336 is merged. Sorry :D Other than that, logs look good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking this here so no accidental merged until #2336 is merged.
Nice! Will accept when we're about to release :) (learned my lesson) |
What about #2330. As you labeled it for 10.4.0, it's fine to merge? |
Yes, I think this can / should go into |
@polarathene are you going to release this on the 24th?:) |
Sure, is there a specific timezone? Otherwise I'd be happy to release around this time tomorrow (which is 24th in NZ) |
Nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as @polarathene cannot approve his own PR
Description
This PR marks the feature freeze phase for the
v10.4.0
release.The current
:edge
image will be tested for roughly one week and if no bugs get reported,v10.4.0
will be released. During this testing period, only PRs that do not change functionality will be merged.If you want to support us, give the latest
:edge
image a try and report any issues you encounter back to this PR.Feature freeze is in place until 24 Dec 2021. Documentation updates may be merged.
Type of change
Release-Checklist: