Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: version v10.4.0 #2328

Merged
merged 7 commits into from
Dec 23, 2021
Merged

release: version v10.4.0 #2328

merged 7 commits into from
Dec 23, 2021

Conversation

polarathene
Copy link
Member

@polarathene polarathene commented Dec 18, 2021

Description

This PR marks the feature freeze phase for the v10.4.0 release.

The current :edge image will be tested for roughly one week and if no bugs get reported, v10.4.0 will be released. During this testing period, only PRs that do not change functionality will be merged.

If you want to support us, give the latest :edge image a try and report any issues you encounter back to this PR.

Feature freeze is in place until 24 Dec 2021. Documentation updates may be merged.

Type of change

  • Release

Release-Checklist:

  • Update CHANGELOG.md
  • Update version in VERSION
  • Draft release

@polarathene polarathene added the kind/release This PR marks a release label Dec 18, 2021
@polarathene polarathene added this to the v10.4.0 milestone Dec 18, 2021
@polarathene polarathene self-assigned this Dec 18, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@casperklein
Copy link
Member

I recommend approving such kind of PRs only after successful testing.

@georglauterbach
Copy link
Member

georglauterbach commented Dec 20, 2021

You're right, will do.

@georglauterbach
Copy link
Member

georglauterbach commented Dec 20, 2021

"Don't count your chickens before they are hatched." @casperklein you we're right. I just checked the logs again and found something... (but nothing serious). Enough to block this PR though until #2336 is merged. Sorry :D

Other than that, logs look good to me.

Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking this here so no accidental merged until #2336 is merged.

@georglauterbach georglauterbach added the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Dec 20, 2021
@georglauterbach
Copy link
Member

Nice! Will accept when we're about to release :) (learned my lesson)

@casperklein
Copy link
Member

What about #2330. As you labeled it for 10.4.0, it's fine to merge?

@georglauterbach
Copy link
Member

georglauterbach commented Dec 20, 2021

What about #2330. As you labeled it for 10.4.0, it's fine to merge?

Yes, I think this can / should go into v10.4 too. We can then remove the label
pr/waiting for other PR to get merged label from this PR and freeze other PRs if necessary.

@casperklein casperklein removed the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Dec 21, 2021
@georglauterbach
Copy link
Member

@polarathene are you going to release this on the 24th?:)

@polarathene
Copy link
Member Author

@polarathene are you going to release this on the 24th?:)

Sure, is there a specific timezone? Otherwise I'd be happy to release around this time tomorrow (which is 24th in NZ)

@georglauterbach
Copy link
Member

@polarathene are you going to release this on the 24th?:)

Sure, is there a specific timezone? Otherwise I'd be happy to release around this time tomorrow (which is 24th in NZ)

Nice!
I think time zone does not matter, just go ahead :)

Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as @polarathene cannot approve his own PR

@polarathene polarathene merged commit 061bae6 into master Dec 23, 2021
@polarathene polarathene deleted the release/10.4.0 branch December 23, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release This PR marks a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants