Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added libldap-common to packages in Dockerfile #2341

Merged
merged 1 commit into from Dec 25, 2021

Conversation

georglauterbach
Copy link
Member

Description

Fixes an issue concerning a package missing on Debian 11. This issue may justify v10.4.1 - please add your opinions on that.

Fixes #2340

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach self-assigned this Dec 25, 2021
@georglauterbach georglauterbach added this to the v10.4.1 milestone Dec 25, 2021
@georglauterbach georglauterbach changed the title added libldap-common to packages in Dockerfile added libldap-common to packages in Dockerfile Dec 25, 2021
Copy link
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue may justify v10.4.1

ack

@georglauterbach georglauterbach merged commit 701037d into master Dec 25, 2021
@georglauterbach georglauterbach deleted the fix/libldap-common branch December 25, 2021 19:44
@polarathene
Copy link
Member

Any reason our tests didn't catch that as a failure..?

@casperklein
Copy link
Member

There are other packages missing, renamed or version bumped, but I don't have time right now to check them:

diff <(docker run --rm -t mailserver/docker-mailserver:10.3 bash -c 'apt list' | cut -d/ -f1 | sort) \
     <(docker run --rm -t mailserver/docker-mailserver:10.4 bash -c 'apt list' | cut -d/ -f1 | sort)

At a first very quick look, fdisk is missing in 10.4. But that's definitely not essential for a mailserver..

@georglauterbach georglauterbach modified the milestones: v10.4.1, v10.5.0 Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 10.4 - dovecot + LDAPS - TLS broken due to missing package libldap-common in docker container
4 participants