Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTORS): update contributors #2352

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2022

docs(CONTRIBUTORS): update contributors

Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did someone got removed? Like what must happened that the contributors get smaller?

@casperklein
Copy link
Member

casperklein commented Jan 1, 2022

Idk. But the user is also not listed (anymore?) in https://github.com/docker-mailserver/docker-mailserver/graphs/contributors

@georglauterbach
Copy link
Member

I guess the use deleted his account?

@polarathene
Copy link
Member

I guess the user deleted his account?

No it's still active, they are one of the new contributors listed in the 10.4.0 release.

Not sure why they don't appear on the contributors graph anymore, might be a privacy option?

@casperklein
Copy link
Member

might be a privacy option?

I thought about the same, but couldn't find an option in the settings.

@wernerfred
Copy link
Member

Could it be that the Account changed its handle? Like @georglauterbach did Last Year?

@georglauterbach
Copy link
Member

georglauterbach commented Jan 2, 2022

Could it be that the Account changed its handle? Like @georglauterbach did Last Year?

Very plausible, but I think when I did that, my contributions did not get low, AFAIK. But still an option.

Double-checked. Does not seem to be the case. Tagging @gutmensch here, maybe he can resolve the matter :)

@gutmensch
Copy link
Contributor

Ah sorry for the noise folks, I indeed changed my mail address lately and checked "Keep my email addresses private" without knowing the implications (as the github information was not really helpful for this option). Fixed, thanks for the ping!

@georglauterbach
Copy link
Member

Alright. The contributors bot should, with its next PR, re-add the user, right?

@casperklein
Copy link
Member

I don't think so, as long as the user does not reappear on the Github contributors page. It would be odd, if the API would return other contributors, than the page.

@georglauterbach
Copy link
Member

georglauterbach commented Jan 3, 2022

I don't think so, as long as the user does not reappear on the Github contributors page. It would be odd, if the API would return other contributors, than the page.

I see, that makes sense. I'd go ahead an merge this PR anyways. @gutmensch if you'd like to re-appear on the contributors' page, just create a PR where a typo is fixed or something else :) (I'll leave this open for another day if there are objections to merging this.)

@gutmensch
Copy link
Contributor

Yep, please go ahead and nvm, I added the original commit e-mail address back to my profile and made them public again, so AFAIU github should be able to map the contribution (and I don‘t have any type-o), but it’s really too much chat already for such a small change and what github API is doing here is beyond me anyway. 😄 Please do merge, thanks for reaching out!

@georglauterbach georglauterbach merged commit f68878a into master Jan 3, 2022
@georglauterbach georglauterbach deleted the contributors-update branch January 3, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants