add env var LOGWATCH_SENDER

[craue]

Description

Follow-up to #2360, but using /etc/logwatch/conf/logwatch.conf as config file.

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

This might be considered to be a breaking change if someone relied on the fact that REPORT_SENDER wouldn't influence the sender address for logwatch reports. But when I started using this project, I was actually expecting it would.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md or the documentation under docs/)
• If necessary I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[craue]

I've fixed the issue's description because I just noticed that POSTMASTER_ADDRESS wouldn't bubble to LOGWATCH_SENDER or PFLOGSUMM_SENDER. The documenation for PFLOGSUMM_SENDER was already wrong and I just copied it. Shall I fix the comments for both sender vars?

[georglauterbach]

I've fixed the issue's description because I just noticed that POSTMASTER_ADDRESS wouldn't bubble to LOGWATCH_SENDER or PFLOGSUMM_SENDER. The documenation for PFLOGSUMM_SENDER was already wrong and I just copied it.

What do you mean by "bubble"?

Shall I fix the comments for both sender vars?

Sure :)

[craue]

I've fixed the issue's description because I just noticed that POSTMASTER_ADDRESS wouldn't bubble to LOGWATCH_SENDER or PFLOGSUMM_SENDER. The documenation for PFLOGSUMM_SENDER was already wrong and I just copied it.

What do you mean by "bubble"?

I mean that the value of a variable will also set another variable if it's not explicitly set otherwise.

Sure :)

Will do.

[casperklein]

Don't forget to adjust start-mailserver.sh as well. As of now, the new env can't be used.

[georglauterbach]

Don't forget to adjust start-mailserver.sh as well. As of now, the new env can't be used.

Isn't it enough that they're set up in _setup_default_vars in setup-stack.sh?

[casperklein]

I think you are right. I find it always confusing, when default vars are defined in two places 😕

[georglauterbach]

I think you are right. I find it always confusing, when default vars are defined in two places confused

Very true. I guess the variables in _setup_default_vars need some setup beforehand (like hostname and stuff). That#s why they're located in that specific place.

[craue]

Not sure about the failing test. Is it related to my changes?

Edit: Interesting... now the failure is gone. 😮

[github-actions]

Documentation preview for this PR is ready! 🎉

Built with commit: 267c872

[georglauterbach]

Not sure about the failing test. Is it related to my changes?

Edit: Interesting... now the failure is gone. 😮

Sometimes, although not too often, a test is flakey and does not behave well. Restarting the jobs solves these problems.