Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for sedfile wrapper #2363

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Add tests for sedfile wrapper #2363

merged 2 commits into from
Jan 10, 2022

Conversation

casperklein
Copy link
Member

Description

Add tests for the sedfile wrapper.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Jan 8, 2022
@casperklein casperklein added area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Jan 8, 2022
@casperklein casperklein requested a review from a team January 8, 2022 13:36
@casperklein casperklein added this to the v10.5.0 milestone Jan 8, 2022
@casperklein casperklein marked this pull request as ready for review January 8, 2022 13:36
georglauterbach
georglauterbach previously approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@casperklein casperklein requested review from georglauterbach and a team January 9, 2022 02:08
@georglauterbach georglauterbach requested a review from a team January 9, 2022 16:28
@casperklein casperklein merged commit 4ae04f0 into docker-mailserver:master Jan 10, 2022
@casperklein casperklein deleted the sedfile-test branch January 10, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels
area/tests kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casperklein @polarathene @georglauterbach