Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double occurence of /etc/postfix/regexp #2397

Merged
merged 6 commits into from
Feb 11, 2022
Merged

fix: double occurence of /etc/postfix/regexp #2397

merged 6 commits into from
Feb 11, 2022

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Feb 7, 2022 •
edited

Description

/etc/postfix/regexp appeared twice in Postfix's virtual_alias_maps. This should be corrected now.

PS: It turns out, without this PR, every time a change is detected, /etc/postfix/regexp will be added again. So this PR is indeed somewhat important :D

Fixes #2394

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added this to the v10.5.0 milestone Feb 7, 2022
@georglauterbach georglauterbach requested a review from a team February 7, 2022 10:01
@georglauterbach georglauterbach self-assigned this Feb 7, 2022
@georglauterbach
Copy link
Member Author

Seems like I broke something. I will have a look again.

@casperklein casperklein marked this pull request as draft February 7, 2022 13:32
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: 0ae2da2

@georglauterbach georglauterbach marked this pull request as ready for review February 7, 2022 21:25
@georglauterbach georglauterbach requested review from casperklein and a team February 8, 2022 11:45
casperklein
casperklein previously approved these changes Feb 8, 2022
View reviewed changes
@georglauterbach georglauterbach requested review from polarathene and a team February 8, 2022 12:02
polarathene
polarathene requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just one typo (not from this PR but that existed before with the warning file path being incorrect).

target/scripts/startup/setup-stack.sh Outdated Show resolved Hide resolved
casperklein and others added 2 commits February 9, 2022 01:26
@casperklein
Merge branch 'master' into fix/issue-2394
07ababc
@georglauterbach @polarathene
Update target/scripts/startup/setup-stack.sh
6a6d67a 
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
@georglauterbach georglauterbach enabled auto-merge (squash) February 9, 2022 08:36
@georglauterbach
Copy link
Member Author

I'd like to release v10.5.0 when this PR and #2361 are merged :D

wernerfred
wernerfred approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@georglauterbach georglauterbach merged commit ce9e86c into master Feb 11, 2022
@georglauterbach georglauterbach deleted the fix/issue-2394 branch February 11, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@wernerfred wernerfred wernerfred approved these changes

@NorseGaud NorseGaud Awaiting requested review from NorseGaud

Assignees

@georglauterbach georglauterbach

Labels
area/scripts priority/medium
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.

[BUG] virtual_alias_maps contains the regexp entry multiple times
4 participants
@georglauterbach @casperklein @polarathene @wernerfred