Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not add accounts that already exists to account files #2419

Merged
merged 10 commits into from
Feb 21, 2022
Merged

fix: do not add accounts that already exists to account files #2419

merged 10 commits into from
Feb 21, 2022

Conversation

georglauterbach
Copy link
Member

Description

Includes a fix with which users are not added to the accounts files of Postfix and Dovecot if they are already present.

Fixes #2416

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added this to the v10.5.0 milestone Feb 18, 2022
@georglauterbach georglauterbach self-assigned this Feb 18, 2022
@georglauterbach
Do the same for aliases
c630177 
Somehow I forgot to check for aliases (which actually caused the
original issue to be opened...). This commit fixes the issue properly
and also introduces warning messages when aliases or accountts are
about to be added twice.
This was referenced Feb 18, 2022
Closed
Closed
casperklein
casperklein reviewed Feb 18, 2022
View reviewed changes
target/scripts/helpers/accounts.sh Outdated Show resolved Hide resolved
target/scripts/helpers/accounts.sh Outdated Show resolved Hide resolved
target/scripts/helpers/accounts.sh Outdated Show resolved Hide resolved
@georglauterbach @casperklein
Apply suggestions from code review
3af5602 
Co-authored-by: Casper <casperklein@users.noreply.github.com>
@georglauterbach
Copy link
Member Author

Cancelled the current workflow because I will push another commit soon. I don't like wasting compute time (even if it's not mine 😆)

casperklein
casperklein previously approved these changes Feb 20, 2022
View reviewed changes
polarathene
polarathene requested changes Feb 20, 2022
View reviewed changes
target/scripts/helpers/accounts.sh Outdated Show resolved Hide resolved
@georglauterbach @polarathene
Update target/scripts/helpers/accounts.sh
b8a4947 
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
@georglauterbach georglauterbach mentioned this pull request Feb 21, 2022
Merged
7 tasks
@georglauterbach georglauterbach merged commit 399284c into master Feb 21, 2022
@georglauterbach georglauterbach deleted the fix/2416 branch February 21, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@NorseGaud NorseGaud Awaiting requested review from NorseGaud

@wernerfred wernerfred Awaiting requested review from wernerfred

Assignees

@georglauterbach georglauterbach

Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/medium service/dovecot service/postfix
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.

mail dovecot: auth: Error: passwd-file /etc/dovecot/userdb: User user@mydomain.com exists more than once
3 participants
@georglauterbach @casperklein @polarathene