-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(podman): Fix broken links and add version hints #2429
docs(podman): Fix broken links and add version hints #2429
Conversation
b87bc5c
to
e22b320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Version warning should afaik not be necessary as the docs are Versioned as well and released Always together with a new Container Version.
Looking at the "Edge" Docs is valid for the "Edge" build of the Container. But switching to Docs Version "10.4" (which counts for the 10.4 builds) will not contain the newest additions.
In fact we implemented the Versioned Docs for exactly that reason, to avoid updating references and Versions throughout the Docs.
If it Happens to be the Case that "newer" Docs are in a "older" Release we messed Up the Release/merge process but not the Docs (content)
Hmm, seems like I should enable JS every once in a while... Now I see the versioning dropdown 😄 I'll revert the versioning related changes from the docs. Should I also revert the change in this line in the env file? |
Yes. The |
e22b320
to
1d0b909
Compare
Documentation preview for this PR is ready! 🎉 Built with commit: 1d0b909 |
Alright, I've reverted all changes except for the typo and the broken links 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
This is a follow up of #2393, where I accidentally added broken links to the podman documentation.
In addition to this fix, I've added some version hints to the changes introduced in the aforementioned PR to circumvent issues like this
Type of change
Checklist:
docs/
)