Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: version v10.5.0 #2431

Merged
merged 4 commits into from
Mar 2, 2022
Merged

release: version v10.5.0 #2431

merged 4 commits into from
Mar 2, 2022

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Feb 22, 2022

Description

This PR marks the feature freeze phase for the v10.5.0 release.

The current :edge image will be tested for roughly one week and if no bugs get reported, v10.5.0 will be released. During this testing period, only PRs that do not change functionality will be merged.

If you want to support us, give the latest :edge image a try and report any issues you encounter back to this PR.

Documentation updates may be merged. Feature freeze is in place until 01 March 2022.

(Previously) Blocking:

Until it is decided whether they go into this release or not, 10.5.0's feature free is not in place.

EDIT: I seems as if a decision was reached. #2424 and #2428 are breaking changes and require a major version bump.

Type of change

  • Release

Release-Checklist:

  • Update CHANGELOG.md
  • Update version in VERSION
  • Draft release

@georglauterbach georglauterbach added meta/needs triage This issue / PR needs checks and verification from maintainers priority/high kind/release This PR marks a release labels Feb 22, 2022
@georglauterbach georglauterbach added this to the v10.5.0 milestone Feb 22, 2022
@georglauterbach georglauterbach requested a review from a team February 22, 2022 11:23
@georglauterbach georglauterbach self-assigned this Feb 22, 2022
@georglauterbach georglauterbach removed the meta/needs triage This issue / PR needs checks and verification from maintainers label Feb 22, 2022
Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Putting together all PRs 🚀
For Future us: We could think of Auto-generating the Changelog / Release content through CI

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to support us, give the latest :edge image a try and report any issues you encounter back to this PR.

No problems in my setup 👍

I thought about, how to get more people testing the edge image. There seems to be no way to pin PRs like issues. Maybe next time, we open/pin also a an issue about the upcoming release?

@georglauterbach
Copy link
Member Author

I thought about, how to get more people testing the edge image. There seems to be no way to pin PRs like issues. Maybe next time, we open/pin also a an issue about the upcoming release?

We could, as an alternative, open a discussion (type: announcement). Maybe this is more fitting.

@georglauterbach
Copy link
Member Author

What say ye @docker-mailserver/maintainers? :D

@NorseGaud NorseGaud self-requested a review March 1, 2022 13:38
@NorseGaud
Copy link
Member

I see nothing that would cause me to reject it :)

@georglauterbach
Copy link
Member Author

Release was scheduled for today, but this PR lacks approval. Currently, changes requested by @wernerfred are blocking and @polarathene has not approved either. There is no rush, just wanted to let you know.

Copy link
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I didn't approve in a first place as I hadn't time to test edge. Didn't notice that the change request is still blocking after it got adressed. Hope this "Reviewal Comment" will superseed the Change Request.

EDIT: Seems like a comment will only be added to the reviews, not replace a previous one. I'll find a way to remove the blocker
EDIT: It worked 👍🏻

@wernerfred wernerfred dismissed their stale review March 1, 2022 20:01

Dismiss as requested change was implemented

@polarathene
Copy link
Member

@polarathene has not approved either

I still don't actually run this project, only contribute/maintain 😅

I can approve but I've not done any testing on my end.

@georglauterbach
Copy link
Member Author

@polarathene has not approved either

I still don't actually run this project, only contribute/maintain sweat_smile

I can approve but I've not done any testing on my end.

While this is true, there is no hard requirement that forces you to use :edge to approve this PR. Otherwise I assume there is a very valid reason for not approving this PR so I will not merge it :)

@georglauterbach georglauterbach merged commit 4203afe into master Mar 2, 2022
@georglauterbach georglauterbach deleted the release/10.5.0 branch March 2, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release This PR marks a release priority/high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants