Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove legacy functions / tests #2434

Merged
merged 6 commits into from
Mar 2, 2022

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Feb 23, 2022

Description

In old bats versions, there was no native support for the setup_file, teardown_file functions. To get this working, workaround functions and dummy tests (@test "first, @test "last") were added.

Since our bats version does support those functions out-of-the-box for some time now and there is no need for the dummy functions / test anymore, they have been removed.

CI: This will also remove plenty of message like this while running the tests:

ok 5 first # skip This version natively supports setup/teardown_file

@martin-schulze-vireso IIRC, you wrote most of these tests. I wasn't able to add you as a reviewer, but you might also take a look and confirm, if everything is alright.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein marked this pull request as ready for review February 23, 2022 15:11
@casperklein casperklein requested a review from a team February 23, 2022 15:15
Copy link
Contributor

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Its funny how this issue made me end up as maintainer of Bats... Nice to see my work bear fruit. Thanks @ALL for giving docker-mailserver new drive.

Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nince! This was bothering me for a long time now.

@georglauterbach georglauterbach added area/tests kind/improvement Improve an existing feature, configuration file or the documentation meta/feature freeze On hold due to upcoming release process labels Feb 23, 2022
@georglauterbach georglauterbach added this to the v11.0.0 milestone Feb 23, 2022
@georglauterbach georglauterbach removed the meta/feature freeze On hold due to upcoming release process label Mar 2, 2022
@casperklein casperklein merged commit 6d1c740 into docker-mailserver:master Mar 2, 2022
@casperklein casperklein deleted the cleanup-tests branch March 2, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants