-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remove legacy functions / tests #2434
tests: remove legacy functions / tests #2434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Its funny how this issue made me end up as maintainer of Bats... Nice to see my work bear fruit. Thanks @ALL for giving docker-mailserver new drive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nince! This was bothering me for a long time now.
Description
In old bats versions, there was no native support for the
setup_file
,teardown_file
functions. To get this working, workaround functions and dummy tests (@test "first, @test "last"
) were added.Since our bats version does support those functions out-of-the-box for some time now and there is no need for the dummy functions / test anymore, they have been removed.
CI: This will also remove plenty of message like this while running the tests:
ok 5 first # skip This version natively supports setup/teardown_file
@martin-schulze-vireso IIRC, you wrote most of these tests. I wasn't able to add you as a reviewer, but you might also take a look and confirm, if everything is alright.
Type of change
Checklist:
docs/
)