chore: Drop setup.sh DATABASE fallback ENV
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced without any mention or need, thus removing until a real use-case requires it.
Likewise, nothing requires this to be customizable.
11 tasks
casperklein
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
DATABASEENV fallback was added in this Dec 2016 PR, no justification was provided.Likewise for
USER_DATABASEindelquotaandaddquotafiles in Apr 2020 which was probably based on the earlier existing convention used forDATABASE.Neither are in usage by our tests or detailed in documentation.
These are being dropped as a recent PR adapted existing scripts where
DATABASEwith an ENV fallback would be conflicting with usage elsewhere unless providing a temporary ENV when calling the command.Until an actual use-case requires this, it's probably best to drop such support.