Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update faq.md #2558

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Update faq.md #2558

merged 1 commit into from
Apr 20, 2022

Conversation

ontheair81
Copy link
Contributor

Description

  • Altering introduction which mentions Docker volumes as default, which is not true anymore.
  • Corrected typo ("log" instead of "logs").
  • Removed warning that Docker volumes are strongly recommended to avoid data loss, as this can lead new users in the wrong direction as bind mounts are now the default.

This is my first ever pull request, so please be forgiving if I did something wrong ;-)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ontheair81
Update faq.md
18c865e 
Removed typo in line 78 ("log" instead of "logs".
Removed warning that Docker volumes are strongly recommended, as this can lead new users in the wrong direction (bind mounts are now the default).
Altering line 8, mentioning the default of bind mounts.
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 18c865e

@casperklein casperklein requested a review from a team April 20, 2022 16:24
@casperklein casperklein added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Apr 20, 2022
casperklein
casperklein approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 👍

georglauterbach
georglauterbach approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@polarathene polarathene merged commit 377bdb3 into docker-mailserver:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees
No one assigned
Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ontheair81 @casperklein @polarathene @georglauterbach