Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: remove unnecessary quotes from command substitutions #2561

Merged

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Apr 27, 2022

Description

This PR streamlines our code base, by removing unnecessary quotes from command substitutions:

FOO="$(command  "arg")"

becomes

FOO=$(command "arg")

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v11.1.0 milestone Apr 27, 2022
@casperklein casperklein self-assigned this Apr 27, 2022
@casperklein casperklein marked this pull request as ready for review April 27, 2022 10:08
@casperklein casperklein requested a review from a team April 27, 2022 10:08
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 27, 2022
@casperklein casperklein merged commit 628e902 into docker-mailserver:master May 5, 2022
@casperklein casperklein deleted the command-substitutions-quotes branch May 5, 2022 08:28
@georglauterbach georglauterbach changed the title Remove unnecessary quotes from command substitutions scripts: remove unnecessary quotes from command substitutions May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants