Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: don't issue warning when DKIM is not used #2563

Merged
merged 2 commits into from
Apr 29, 2022
Merged

scripts: don't issue warning when DKIM is not used #2563

merged 2 commits into from
Apr 29, 2022

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented Apr 27, 2022 •
edited

Description

Analog to these changes, don't issue a warning when DKIM is not used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 27, 2022
@casperklein casperklein added this to the v11.1.0 milestone Apr 27, 2022
@casperklein casperklein self-assigned this Apr 27, 2022
@casperklein casperklein requested a review from a team April 27, 2022 16:04
@casperklein casperklein marked this pull request as ready for review April 27, 2022 16:05
georglauterbach
georglauterbach approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I missed this when adjusting the levels - thank‘s for noticing :D

@casperklein casperklein merged commit 32fba30 into docker-mailserver:master Apr 29, 2022
@casperklein casperklein deleted the dkim-warning branch April 29, 2022 17:03
@georglauterbach georglauterbach changed the title Don't issue warning when DKIM is not used scripts: don't issue warning when DKIM is not used May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels
area/scripts kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v11.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casperklein @wernerfred @georglauterbach