New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: use color variables instead of escape codes #2565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's clear from the variable name what the usage is
I'm not sure if that applies to ${RESET}
though?
Depending on which PR gets merged first, might want to keep #2535 in mind since it's adding a bunch of new setup
commands that would need to be converted.
Standing alone, maybe not. But it's only used in context of color usage so I think it's fine. |
To not make things harder for #2535, I'll wait with merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we, in the future, realize that we may need the prefix we can always add it :)
Description
This PR streamlines the color usage of the scripts. Color variables are now globally defined in
log.sh
. I did not use a separate file likecolors.sh
, because some scripts only sourcelog.sh
Type of change
Checklist:
docs/
)