Adding the PERMIT_DOCKER option #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See README.md for more informations
|
Job restarted. |
|
You should add functional tests (have a look to |
|
Done |
| @test "checking PERMIT_DOCKER: mynetworks option exist" { | ||
| run docker exec mail /bin/sh -c "postconf -d | grep '^mynetworks ='" | ||
| [ "$status" -eq 0 ] | ||
| } |
There was a problem hiding this comment.
This will be always true because a default value exists in the main.cf
|
The test should be the existing one, testing different value of the variable (empty, host, network). |
|
Otherwise the coverage remains low. |
|
Ok I will make some test with the different containers. |
Fix docker network range Adding opendkim and openmarc configuration
|
@tomav The Travis build is blocked again. |
|
Done |
|
Thank you @Zehir, great enhancement! |
mathuin
pushed a commit
to mathuin/docker-mailserver
that referenced
this pull request
Aug 21, 2016
* Adding the PERMIT_DOCKER option See README.md for more informations * Adding some test for PERMIT_DOCKER option * Fix test cases * Opendkim and Openmarc configuration Fix docker network range Adding opendkim and openmarc configuration * Adding some options for tests * Update log message * Update tests
|
Sorry if the question is stupid guys, What would be the recipe for disabling all SMTP attmpts except those within 😕 |
RichardFevrier
pushed a commit
to RichardFevrier/docker-mailserver
that referenced
this pull request
Aug 26, 2019
* Adding the PERMIT_DOCKER option See README.md for more informations * Adding some test for PERMIT_DOCKER option * Fix test cases * Opendkim and Openmarc configuration Fix docker network range Adding opendkim and openmarc configuration * Adding some options for tests * Update log message * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README.md for more informations
Enhancement #261