tests: Update submodules for bats #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two submodules were migrated to the `bats-core` organization, where they continued to receive updates.
This is technically one commit backwards, but no relevant difference has been made since, other than moving the submodule to the `bats-core` organization.
No official release tag since Nov 2018, but a fair amount of changes since then.
polarathene
added
area/ci
priority/low
area/tests
kind/update
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Assertions often depend on the output of the last `run` command. These tests were either missing a `run`, or incorrectly asserting against the wrong command they were intended for. `wait_for_service` should not be asserted. It is just a pre-requisite before the actual test case is ready to proceed. Updating bats and submodules helped surface this testing bug.
These commands used `run` with no assertion. If they were meant to assert success, they should include `assert_success` after each `run`. Until a failure occurs, it is assumed these commands are not under test, and just part of setting up the test case.
|
That should fix the failures. Additional information regarding those changes is available in the commit messages. |
|
I am currently re-running the tests as there were some weird quota errors. We'll see what happens in the second run. |
This test was attempting to add the same accounts as in the previous test, which failed. It was undetected previously due to the error being caught by `run` with no assertion to detect it.
|
Tests are passing now.
|
georglauterbach
approved these changes
Aug 11, 2022
casperklein
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
batssubmodules. Notably thebats-assertandbats-supportsubmodules have since been migrated to thebats-coreorganization, while our current remote has been unmaintained since 2016.bats-coreour last release of1.4.1(July 2021) updated to1.7.0(May 2022). Some fixes and newsetup_suite()+teardown_suite()options to run once before and after all individual test files (setup_file()/teardown_file()) are handled.bats-asserthas had a fair amount of updates. I've opted to update to the current master commit as no official release has been tagged since Nov 2018. There is a request for a new tagged release since Jan 2021. There is some new assertions since the last release, such asassert_not_equal.bats-supporthas had no new relevant activity for us since.Type of change
Checklist: