Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add outputs to workflow_call on generic_build #2780

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Sep 19, 2022

Description

Looking at https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow, we can see that we need to manually set the outputs for a whole generic workflow. This commit fixes an issue where the cache key was not set properly as the input was empty (because the output of the previous job was not actually set).

For reference, see #2772 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Looking at
https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow,
we can see that we need to manually set the outputs for a whole generic
workflow. This commit fixes an issue where the cache key was not set
properly as the input was empty (because the output of the previous job
was not actually set).
@georglauterbach georglauterbach added this to the v11.2.0 milestone Sep 19, 2022
@georglauterbach georglauterbach self-assigned this Sep 19, 2022
@georglauterbach georglauterbach changed the title add outputs to workflow_call on generic_build ci: add outputs to workflow_call on generic_build Sep 19, 2022
@georglauterbach georglauterbach merged commit 7fe6748 into master Sep 21, 2022
@georglauterbach georglauterbach deleted the ci/fix-cache-issues branch September 21, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants