Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: cleaned up Makefile #2833

Merged
merged 4 commits into from
Oct 16, 2022
Merged

build: cleaned up Makefile #2833

merged 4 commits into from
Oct 16, 2022

Conversation

georglauterbach
Copy link
Member

Description

Got some inspiration from comments in #2822 and decided to clean up the whole Makefile.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
cleaned up Makefile
5371981 
Got some inspiration from comments in #2822 and decided to clean up the
whole `Makefile`.
@georglauterbach georglauterbach added area/ci kind/improvement Improve an existing feature, configuration file or the documentation labels Oct 15, 2022
@georglauterbach georglauterbach added this to the v11.3.0 milestone Oct 15, 2022
@georglauterbach georglauterbach self-assigned this Oct 15, 2022
casperklein
casperklein reviewed Oct 15, 2022
View reviewed changes
Makefile Show resolved Hide resolved
polarathene
polarathene previously approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions, but nothing block, LGTM 👍

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@georglauterbach georglauterbach enabled auto-merge (squash) October 16, 2022 09:53
@georglauterbach
Copy link
Member Author

Applied PR feedback and merged master to be up-to-date. Also enabled auto-merge :)

@georglauterbach georglauterbach merged commit 284c44f into master Oct 16, 2022
@georglauterbach georglauterbach deleted the improve-make branch October 16, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels
area/ci kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v11.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georglauterbach @casperklein @polarathene