Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update to new output format on GH actions #2892

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Nov 5, 2022

Description

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Type of change

  • Update to component due to deprecation notice

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@georglauterbach georglauterbach added area/ci kind/update Update an existing feature, configuration file or the documentation labels Nov 5, 2022
@georglauterbach georglauterbach added this to the v11.3.0 milestone Nov 5, 2022
@georglauterbach georglauterbach self-assigned this Nov 5, 2022
@casperklein
Copy link
Member

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works

Are you sure? 😄

@georglauterbach
Copy link
Member Author

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works

Are you sure? smile

Not sure I follow, haha :D What did I miss?:)

@casperklein
Copy link
Member

I have made corresponding changes to the documentation

You did not make changes to the docs for example ;-)

@georglauterbach
Copy link
Member Author

I have made corresponding changes to the documentation

You did not make changes to the docs for example ;-)

I always read this like "if there changes to the docs necessary, I did them" 🙈 I can adjust the description though 🙃

@georglauterbach georglauterbach merged commit 2bc4078 into master Nov 7, 2022
@georglauterbach georglauterbach deleted the gh/update-workflows branch November 7, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci kind/update Update an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants