Add the option of manually specifying paths to SSL certificates #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @keslerm, could you add a functional test on this part? Thank you. |
|
Sure can, wanted to get some feedback before I tried to figure out the tests. |
|
Thanks. |
RichardFevrier
pushed a commit
to RichardFevrier/docker-mailserver
that referenced
this pull request
Aug 26, 2019
…er-mailserver#296) * Add the option of manually specifying paths to SSL certificates * Adding tests for manual SSL changes
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to directly specify the paths to my SSL certificates to solve getting this running within a Kubernetes cluster where my SSL certificates are managed by kube-lego.
Kubernetes will let me mount the secret volume (which is where the ssl keys are stored) into the container, but the "self signed" and "custom" options really work with that.
This will let you define two additional env variables
SSL_CERT_PATH
SSL_KEY_PATH
Honestly just being able to manually tell what SSL certificates is very handy since obviously not everyone fits in a specific structure.
Let me know what you think or if there is anything I can improve!