Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarification of description of explicit TLS #3017

Merged
merged 4 commits into from
Jan 22, 2023
Merged

docs: clarification of description of explicit TLS #3017

merged 4 commits into from
Jan 22, 2023

Conversation

i-C-o-d-e-r
Copy link
Contributor

@i-C-o-d-e-r i-C-o-d-e-r commented Jan 21, 2023 •
edited

Description

Changed description of explicit TLS to indicate that insecure connections are rejected
Fixes #3007

Type of change

  • Clarification of description of Explicit TLS

@georglauterbach georglauterbach self-assigned this Jan 21, 2023
@georglauterbach georglauterbach added kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels Jan 21, 2023
@georglauterbach georglauterbach changed the title Clearification of description of explicit TLS docs: clarification of description of explicit TLS Jan 22, 2023
polarathene
polarathene requested changes Jan 22, 2023
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to improve our documentation! 🙏

I've expanded on your addition a bit more to clarify that it only applies to authentication (to submit mail to send, or to retrieve mail to a MUA), but does not apply to receiving mail from third-parties on port 25 👍

docs/content/config/security/understanding-the-ports.md Outdated Show resolved Hide resolved
@polarathene polarathene added this to the v12.0.0 milestone Jan 22, 2023
@i-C-o-d-e-r @polarathene
Further clarification that description only applies to authentication
a44d80f 
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
georglauterbach
georglauterbach approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 92e7675

@polarathene polarathene merged commit b2cd66f into docker-mailserver:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@georglauterbach georglauterbach

Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.

Unclear documentation for the description of the port 110
3 participants
@i-C-o-d-e-r @polarathene @georglauterbach