New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Amavis): only add configuration to Postfix when enabled #3046
Conversation
Since I am running Rspamd nowadays, I noticed there still are ports open that belong to Amavis. This is because the Amavis configuration is a fixed part of Postfix's `master.cf`. I changed that. Now, the Amavis section is added when Amavis really is enabled. I took the chance and added proper indentation to `master.cf`; hence the diff is a bit fuzzy. **But**, only the Amavis part was adjusted, the rest is just styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure about storing the config in /etc/amavis
within the container, but otherwise no other concerns 👍
Might be worth doing similar for the other 3 additions we have, but these are all default and not configurable I think. pickup
in particular is modifying the original pickup
config.
If I get around to refactoring the relay feature support, it'd be taking a similar approach to this Amavis appending. So I'm a bit more swayed towards a common location in the container (/etc/dms/postfix/master.d
?)
I updated the file location inside the container (to |
@georglauterbach I noticed this: docker-mailserver/target/postfix/main.cf Lines 88 to 89 in 9e9f802
It's removed if docker-mailserver/target/scripts/startup/setup-stack.sh Lines 73 to 82 in 9e9f802
|
* improve Amavis setup routine see #3046 (comment)
Description
Since I am running Rspamd nowadays, I noticed there still are ports open that belong to Amavis. This is because the Amavis configuration is a fixed part of Postfix's
master.cf
. I changed that. Now, the Amavis section is added when Amavis really is enabled.I took the chance and added proper indentation to
master.cf
; hence the diff is a bit fuzzy. But, only the Amavis part was adjusted, the rest is just styling.Type of change
Checklist:
docs/
)