scripts: follow up of #3115 (feedback)

[georglauterbach]

Description

Follow-up of #3115 (branch name of this PR wrong, lol). See
#3115 (comment) for example.

Type of change

• Improvement (non-breaking change that does improve existing functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md or the documentation under docs/)
• If necessary I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[casperklein]

Can this introduce unwanted side-effects with our existing scripts that are called afterwards?

Another option would be, to just use it in the _setup function.

Edit: After a quick grep, we don't seem to use '**/' anywhere else.

[georglauterbach]

I was wondering about this too. But I left it up to the tests. Seems there is one place we need to adjust. I will do this later.

[georglauterbach]

Nevermind, was a sporadic BATS issue.

[georglauterbach]

I decided against this for two reasons:

1. The effects of shopt are not scoped to a function, i.e.

$ cat test.sh
#!/bin/bash

shopt -u globstar
shopt | grep "globstar"

function a() {
  shopt -s globstar
  shopt | grep "globstar"
}

a
shopt | grep "globstar"

$ bash test.sh
globstar     off
globstar     on
globstar     on

Hence, setting this inside the whole setup, i.e. changing the behavior at a certain point, is undesirable. We could turn it off again, but actually setting it as fine I think; we may be able to use it in the future and it does not hurt at all.
2. I want Bash adjustments like shopt or set to be used at the very beginning of scripts so everyone immediately notices them. I plan on introducing set -u and shopt -s inherit_errexit too, and these should go together at the beginning start-mailserver.sh.

[casperklein]

I am aware of that. I didn't express it clearly enough. I meant something like this:

function foo() {
shopt -s globstar
for i in /foo/**/*; do
bar
done
shopt -u globstar
}

Setting globstar in the function and revert it after usage.

[georglauterbach]

I actually think that this feature is useful in general, and having it available everywhere is a nice thing :)