Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: remove superfluous EOF in dmarc_dkim_spf.sh #3266

Conversation

ap-wtioit
Copy link
Contributor

@ap-wtioit ap-wtioit commented Apr 17, 2023

Description

Our CI test logs have lots of:

/usr/local/bin/setup.d/dmarc_dkim_spf.sh: line 106: EOF: command not found

Also discussed in https://github.com/docker-mailserver/docker-mailserver/pull/3263/files#r1167336949 and fixed in #3261

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project

    Note checks only complete with [FIX] shellcheck: do not check .git folder #3267 in place

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

    Note checks only complete with [FIX] shellcheck: do not check .git folder #3267 in place

Info @wt-io-it

@georglauterbach
Copy link
Member

I'm waiting for review of #3261, which contains f62855f - the commit that fixes this error.

I introduced it, very sorry for that, by not reading carefully. I do hope that #3261 can be merged soon, so this should be resolved.

@georglauterbach georglauterbach added the pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged label Apr 17, 2023
@georglauterbach georglauterbach added this to the v12.1.0 milestone Apr 17, 2023
@georglauterbach georglauterbach changed the title [FIX] dmarc_dkim_spf.sh: remove superfluous EOF scripts: remove superfluous EOF in dmarc_dkim_spf.sh Apr 20, 2023
@georglauterbach georglauterbach added area/scripts kind/bug/fix A fix (PR) for a confirmed bug and removed pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged labels Apr 20, 2023
@georglauterbach
Copy link
Member

#3261 still has no review, but this issue should be resolved, so this will be merged.

@georglauterbach georglauterbach merged commit 2b330fd into docker-mailserver:master Apr 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scripts kind/bug/fix A fix (PR) for a confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants