Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Restore missing edit button #3338

Merged
merged 2 commits into from May 14, 2023
Merged

docs: Restore missing edit button #3338

merged 2 commits into from May 14, 2023

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented May 14, 2023 •
edited

Description

A "view source" button can be shown next to the "edit this page" button, both of which must now be explicitly enabled.

Source: https://squidfunk.github.io/mkdocs-material/upgrade/#contentaction

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this May 14, 2023
@casperklein casperklein added area/documentation kind/bug/fix A fix (PR) for a confirmed bug labels May 14, 2023
@casperklein casperklein marked this pull request as ready for review May 14, 2023 20:37
@casperklein casperklein mentioned this pull request May 14, 2023
Merged
11 tasks
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: a811cf8

@casperklein
Copy link
Member Author

Documentation preview for this PR is ready! 🎉

The edit button is back 🚀

@casperklein casperklein enabled auto-merge (squash) May 14, 2023 21:12
georglauterbach
georglauterbach approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, LGTM 🚀

@casperklein casperklein merged commit 7cc0558 into master May 14, 2023
3 checks passed
@casperklein casperklein deleted the casperklein-patch-2 branch May 14, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels
area/documentation kind/bug/fix A fix (PR) for a confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@casperklein @georglauterbach