Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'until' style #3366

Merged

Conversation

casperklein
Copy link
Member

@casperklein casperklein commented May 25, 2023

Description

Change 'until' style from

until true
do
  do_something
done
}

to

until true; do
  do_something
done

Planned follow up style changes:

  • for

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added this to the v13.0.0 milestone May 25, 2023
@casperklein casperklein self-assigned this May 25, 2023
@casperklein casperklein marked this pull request as draft May 25, 2023 23:18
@casperklein casperklein marked this pull request as ready for review May 25, 2023 23:40
@georglauterbach georglauterbach merged commit 8512dba into docker-mailserver:master May 26, 2023
7 checks passed
@casperklein casperklein deleted the change-until-style branch May 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants